[BUG] LED alert condition no longer clears after human input event. #28

New issue

Closed

opened 2023-05-24 19:59:43 -03:00 by ZAdamMac · 2 comments

ZAdamMac commented

2023-05-24 19:59:43 -03:00

(Migrated from github.com)

Behavior: The LED_ALERT LED remains lit after initially lighting, even once a human has interacted with the pet (e.g. by having touched an input button)

Expected behaviour: Pressing any of the input buttons should clear the LED alert light (by turning it off) until the next alert is triggered.

Likely this was caused when the human input stuff was changed in the previous megamerge.

Behavior: The LED_ALERT LED remains lit after initially lighting, even once a human has interacted with the pet (e.g. by having touched an input button) Expected behaviour: Pressing any of the input buttons should clear the LED alert light (by turning it off) until the next alert is triggered. Likely this was caused when the human input stuff was changed in the previous megamerge.

ZAdamMac commented

2023-05-24 20:01:03 -03:00

(Migrated from github.com)

Assigning to the work for FW version 0.2.0.

This regression escaped into the firmware on main because the LEDs on the primary test article were installed backwards. I wish I was kidding, but I'm really not.

Note for future me: this needs to be expressly called out in the development kit assembly instructions.

Assigning to the work for FW version 0.2.0. This regression escaped into the firmware on `main` because the LEDs on the primary test article were installed backwards. I wish I was kidding, but I'm really not. Note for future me: this needs to be expressly called out in the development kit assembly instructions.

ZAdamMac commented

2023-05-24 20:14:31 -03:00

(Migrated from github.com)

[f/rps-minigame 9d50feb] corrects this issue. the interacted_flag var from main.h was replaced with a HID_interacted_flag in the human input code, but main was not updated to interact with this and the ISRs for the various input devices were not updated to interact with this value either; commit corrects that.

[f/rps-minigame 9d50feb] corrects this issue. the interacted_flag var from main.h was replaced with a HID_interacted_flag in the human input code, but main was not updated to interact with this and the ISRs for the various input devices were not updated to interact with this value either; commit corrects that.